Improve account switcher e2e tests - Closes #541 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginacontrino
force-pushed
the
451-account-switcher-tests
branch
from
0aa3c71 to
a1136ac
Compare
ginacontrino
force-pushed
the
451-account-switcher-tests
branch
from
a1136ac to
2d82679
Compare
ginacontrino
force-pushed
the
451-account-switcher-tests
branch
from
2d82679 to
2685489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Some situations were not covered by tests yet
How did I fix it?
Added one test that makes sure that the correct amount of accounts is saved
Note: There is a bug that I wanted to solve + test in this PR, which is that sometimes the deleting does not work properly, I couldn't solve this problem though, and later could not even reproduce it anymore, so that's why this ticket was medium, even though I just added one test
Review checklist